-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing: measure route update latency #3113
Merged
AlexanderYastrebov
merged 1 commit into
master
from
routing/measure-route-update-latency
Jun 17, 2024
Merged
routing: measure route update latency #3113
AlexanderYastrebov
merged 1 commit into
master
from
routing/measure-route-update-latency
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
* add route update latency metric - the time it takes to apply routes update after receival. * remove redundant setting of `created` location to UTC - its value is only exposed via Unix() which is always in UTC. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
routing/measure-route-update-latency
branch
from
June 17, 2024 15:30
39119fa
to
c8e578a
Compare
👍 |
1 similar comment
👍 |
MustafaSaber
referenced
this pull request
in zalando-incubator/kubernetes-on-aws
Jun 20, 2024
* \[docs: cleanup deprecated -lb-healthcheck-interval flag\]\(https://github.com/zalando/skipper/pull/3099\) * \[build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz \]\(https://github.com/zalando/skipper/pull/3105\) * \[build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0\]\(\zalando/skipper#3100) * \[build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0\]\(https://github.com/zalando/skipper/pull/3104\) * \[build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0\]\(https://github.com/zalando/skipper/pull/3102\) * \[build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0\]\(https://github.com/zalando/skipper/pull/3106\) * \[build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61\]\(https://github.com/zalando/skipper/pull/3109\) * \[build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3\]\(https://github.com/zalando/skipper/pull/3110\) * \[build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2\]\(https://github.com/zalando/skipper/pull/3108\) * \[routing: log route update id\]\(https://github.com/zalando/skipper/pull/3112\) * \[build(deps): bump actions/checkout from 4.1.6 to 4.1.7\]\(https://github.com/zalando/skipper/pull/3107\) * \[routing: measure route update latency\]\(https://github.com/zalando/skipper/pull/3113\) * \[doc: mention DCO and what to do in your commit\]\(https://github.com/zalando/skipper/pull/3114\) * \[routing: refactor update id logging\]\(https://github.com/zalando/skipper/pull/3116\) * \[OPA: Add response status to control plane traces\]\(https://github.com/zalando/skipper/pull/3118\) * \[routing: measure CreateFilter latency\]\(https://github.com/zalando/skipper/pull/3115\) Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099 * build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105 * build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100 * build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104 * build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102 * build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106 * build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109 * build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110 * build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108 * routing: log route update id: zalando/skipper#3112 * build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107 * routing: measure route update latency: zalando/skipper#3113 * doc: mention DCO and what to do in your commit: zalando/skipper#3114 * routing: refactor update id logging: zalando/skipper#3116 * OPA: Add response status to control plane traces: zalando/skipper#3118 * routing: measure CreateFilter latency: zalando/skipper#3115 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099 * build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105 * build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100 * build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104 * build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102 * build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106 * build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109 * build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110 * build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108 * routing: log route update id: zalando/skipper#3112 * build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107 * routing: measure route update latency: zalando/skipper#3113 * doc: mention DCO and what to do in your commit: zalando/skipper#3114 * routing: refactor update id logging: zalando/skipper#3116 * OPA: Add response status to control plane traces: zalando/skipper#3118 * routing: measure CreateFilter latency: zalando/skipper#3115 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099 * build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105 * build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100 * build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104 * build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102 * build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106 * build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109 * build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110 * build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108 * routing: log route update id: zalando/skipper#3112 * build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107 * routing: measure route update latency: zalando/skipper#3113 * doc: mention DCO and what to do in your commit: zalando/skipper#3114 * routing: refactor update id logging: zalando/skipper#3116 * OPA: Add response status to control plane traces: zalando/skipper#3118 * routing: measure CreateFilter latency: zalando/skipper#3115 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 20, 2024
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099 * build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105 * build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100 * build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104 * build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102 * build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109 * build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110 * build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108 * routing: log route update id: zalando/skipper#3112 * build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107 * routing: measure route update latency: zalando/skipper#3113 * doc: mention DCO and what to do in your commit: zalando/skipper#3114 * routing: refactor update id logging: zalando/skipper#3116 * OPA: Add response status to control plane traces: zalando/skipper#3118 * routing: measure CreateFilter latency: zalando/skipper#3115 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
* add route update latency metric - the time it takes to apply routes update after receival. * remove redundant setting of `created` location to UTC - its value is only exposed via Unix() which is always in UTC. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created
location to UTC - its value is only exposed via Unix() which is always in UTC.